Re: [PATCH v2 1/2] staging: iio: ad7780: update voltage on read

[Renato Lui Geh <renatogeh@xxxxxxxxx>]

Hi Jonathan,

Thank you for the review.

> > +		voltage_uv = regulator_get_voltage(st->reg);
> > +		if (voltage_uv)
> > +			st->int_vref_mv = voltage_uv/1000;
> >  		*val = st->int_vref_mv * st->gain;
> Is there actually a reason (now) to have the stashed value
> of int_vref_mv in the state structure?

> From probe:

if (voltage_uv)
	st->int_vref_mv = voltage_uv / 1000;
else
	dev_warn(&spi->dev, "Reference voltage unspecified\n");

So the idea was to, when voltage_uv = 0, return the previous voltage.
Should I instead handle this as an error the same way as in probe?

Thanks,
Renato
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel