On Wed, Oct 10, 2018 at 8:24 PM Lubomir Rintel <lkundrak@xxxxx> wrote:
>
> It is actually plaform independent. Move it to the olpc-ec driver from
> the X86 OLPC platform, so that it could be used by the ARM based laptops
> too.
What is platform independent exactly?
> #define OLPC_F_PRESENT 0x01
> #define OLPC_F_DCON 0x02
> -#define OLPC_F_EC_WIDE_SCI 0x04
I think these lines grouped on purpose. Thus, I don't like this.
Either move either all or none.
> +int olpc_ec_mask_write(u16 bits)
> +{
> #ifdef CONFIG_DEBUG_FS
>
> /*
> @@ -277,14 +369,17 @@ static int olpc_ec_probe(struct platform_device *pdev)
> ec_priv = ec;
> platform_set_drvdata(pdev, ec);
>
> + /* EC version 0x5f adds support for wide SCI mask */
> + if (ec->version >= 0x5f) {
> + __be16 ec_word = cpu_to_be16(bits);
> +
> + return olpc_ec_cmd(EC_WRITE_EXT_SCI_MASK, (void *) &ec_word, 2,
> + NULL, 0);
I would leave it on one line.
> + } else {
> + unsigned char ec_byte = bits & 0xff;
You may noticed that the parameter is of type u8, which clearly makes
& 0xff part redundant.
> + return olpc_ec_cmd(EC_WRITE_SCI_MASK, &ec_byte, 1, NULL, 0);
> + }
> +}
> +EXPORT_SYMBOL_GPL(olpc_ec_mask_write);
I see that the above is inherited from older code, so, no need to
address those comments in here, but consider a follow up fix.
> +int olpc_ec_sci_query(u16 *sci_value)
> +{
> +}
> +EXPORT_SYMBOL_GPL(olpc_ec_sci_query);
Similar comments are applied here.
> +
> - err = ec_driver->probe ? ec_driver->probe(pdev) : 0;
> + /* get the EC revision */
> + err = olpc_ec_cmd(EC_FIRMWARE_REV, NULL, 0,
> + (unsigned char *) &ec->version, 1);
Perhaps version should be defined as u8.
> +/* SCI source values */
> +#define EC_SCI_SRC_EMPTY 0x00
> +#define EC_SCI_SRC_GAME 0x01
> +#define EC_SCI_SRC_BATTERY 0x02
> +#define EC_SCI_SRC_BATSOC 0x04
> +#define EC_SCI_SRC_BATERR 0x08
> +#define EC_SCI_SRC_EBOOK 0x10 /* XO-1 only */
> +#define EC_SCI_SRC_WLAN 0x20 /* XO-1 only */
> +#define EC_SCI_SRC_ACPWR 0x40
> +#define EC_SCI_SRC_BATCRIT 0x80
> +#define EC_SCI_SRC_GPWAKE 0x100 /* XO-1.5 only */
BIT() ?
> +#define EC_SCI_SRC_ALL 0x1FF
GENMASK()?
--
With Best Regards,
Andy Shevchenko
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
