On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel <lkundrak@xxxxx> wrote: > > It doesn't make sense to always have this built-in, e.g. on ARM > multiplatform kernels. A better way to address the problem the original > commit aimed to solve is to fix Kconfig. > > This reverts commit f48d1496b8537d75776478c6942dd87f34d7f270. > This change doesn't make any sense when put in _this_ order in the series. First, you need to show the CONFIG_OLPC as tristate, which doesn't (Am I missing something?). > Signed-off-by: Lubomir Rintel <lkundrak@xxxxx> > --- > drivers/platform/olpc/olpc-ec.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c > index 374a8028fec7..f99b183d5296 100644 > --- a/drivers/platform/olpc/olpc-ec.c > +++ b/drivers/platform/olpc/olpc-ec.c > @@ -1,8 +1,6 @@ > /* > * Generic driver for the OLPC Embedded Controller. > * > - * Author: Andres Salomon <dilinger@xxxxxxxxxx> > - * > * Copyright (C) 2011-2012 One Laptop per Child Foundation. > * > * Licensed under the GPL v2 or later. > @@ -14,7 +12,7 @@ > #include <linux/platform_device.h> > #include <linux/slab.h> > #include <linux/workqueue.h> > -#include <linux/init.h> > +#include <linux/module.h> > #include <linux/list.h> > #include <linux/olpc-ec.h> > #include <asm/olpc.h> > @@ -328,4 +326,8 @@ static int __init olpc_ec_init_module(void) > { > return platform_driver_register(&olpc_ec_plat_driver); > } > + > arch_initcall(olpc_ec_init_module); > + > +MODULE_AUTHOR("Andres Salomon <dilinger@xxxxxxxxxx>"); > +MODULE_LICENSE("GPL"); > -- > 2.19.0 > -- With Best Regards, Andy Shevchenko _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel