I feel like these are overly nit-picky... I understand that everyone is picky about different things. For example, I have a prefered style for error handling. So two days ago there was a new staging driver and it used label name like "goto kmalloc_failed;" and I looked until I found an error handling bug and then I said, "Here is a bug, plus your label names are bad." When people have bad style but it doesn't lead to bugs then I let them get away with it. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
