On Sat, Oct 06, 2018 at 12:18:38PM +0200, Stefan Wahren wrote: > Hi Tuomas, > > > Tuomas Tynkkynen <tuomas.tynkkynen@xxxxxx> hat am 4. Oktober 2018 um 11:37 geschrieben: > > > > > > Drop various pieces of dead code from here and there to get rid of > > the remaining users of VCHI_CONNECTION_T. After that we get to drop > > entire header files worth of unused code. > > > > I've tested on a Raspberry Pi Model B (bcm2835_defconfig) that > > snd-bcm2835 can still play analog audio just fine. > > > > thanks and i'm fine with your patch series: > > Acked-by: Stefan Wahren <stefan.wahren@xxxxxxxx> > > Unfortunately this would break compilation of the downstream vchi > drivers like vcsm [1]. Personally i don't want to maintain another > one, because i cannot see the gain of the resulting effort. > > [1] - https://github.com/raspberrypi/linux/tree/rpi-4.14.y/drivers/char/broadcom/vc_sm I feel like everyone else already knows the answer but why don't we just merge that code into staging? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
