Please make the subject be: [PATCH] Staging: riffa: Add new RIFFA PCIe driver On Tue, Oct 16, 2018 at 10:54:28AM +0000, Cheng Fei Phung wrote: > This patch adds RIFFA PCIe linux driver for https://github.com/promach/riffa/tree/full_duplex/driver/linux Line wrap the commit message at 75 characters or less. > > TODO: > > 1) this driver needs further speed optimization although it can now achieve defined PCIe speed grade > 2) solve all the coding style errors from scripts/checkpatch.pl Greg means that it needs a file named drivers/staging/riffa/TODO > > Signed-off-by: PHUNG CHENG FEI (feiphung@xxxxxxxxxxx) Please use: Signed-off-by: Cheng Fei Phung <feiphung@xxxxxxxxxxx> It's really unusual for any driver to not use the kernel build system but to come with its own makefile like an out of tree driver... I don't care too much about that because this is staging and we will fix it, but I had wanted to read the Kconfig entry but it's not there... Anyway, this is a staging drive so we're not picky at all. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
