On Fri, 12 Oct 2018 20:55:15 +0000 Haiyang Zhang <haiyangz@xxxxxxxxxxxxxxxxx> wrote: Thanks for fixing this. > + if (kstrtou32(kobject_name(&pdev->slot->kobj), 10, &serial)) { > + netdev_notice(vf_netdev, "Invalid vf serial:%s\n", > + pdev->slot->kobj.name); > + return NULL; > + } Shouldn't this use kobject_name() in the message as well. Looking at the pci.h code there is already an API to get name from slot (it uses kobject_name()). So please use that one. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel