Hi Gao, On Mon, Oct 8, 2018 at 4:48 PM Gao Xiang <gaoxiang25@xxxxxxxxxx> wrote: > > Hi Greg, > > On 2018/10/8 22:43, Greg Kroah-Hartman wrote: > > On Mon, Oct 08, 2018 at 10:36:39PM +0800, Gao Xiang wrote: > >> Hi Greg, > >> > >> On 2018/10/8 22:22, Greg Kroah-Hartman wrote: > >>> Why delete that line? > >>> > >>> But wait, why do we even have this file at all? What's wrong with the > >>> lib/lz4/ code that we have in the kernel today? Shouldn't the code > >>> using these files be moved over to use the lib/ code instead and this > >>> file be deleted? > >> > >> EROFS uses customized LZ4 decompression code for now (which has been offically > >> supported in lz4 1.8.3, I have updated it in > >> https://ozlabs.org/~akpm/mmots/broken-out/lib-lz4-update-lz4-decompressor-module.patch > >> if it is shown up in Linux 4.20, I will remove all the customized LZ4 decompression code), > >> but lib/ code lz4def.h isn't export to include/. > > > > It should show up in 4.20, so you should be able to remove this all > > then. > > Yes, that is correct. I will fix it in 4.20 if the updated LZ4 is already there. :) So no need to update the patch since the file will be removed. Am I correct? Too bad, I'll make my first patch later... ^^ Thanks Loic > > Thanks, > Gao Xiang > > > > > thanks, > > > > greg k-h > > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
