On Mon, Oct 08, 2018 at 09:20:55PM +0800, Gao Xiang wrote: > Hi Loic, > > On 2018/10/8 18:41, Loic Tourlonias wrote: > > Add SPDX identifier to simplify header and remove whole license text > > > > Signed-off-by: Loic Tourlonias <loic.tourlonias.lkml@xxxxxxxxx> > > --- > > drivers/staging/erofs/lz4defs.h | 23 ++--------------------- > > 1 file changed, 2 insertions(+), 21 deletions(-) > > > > diff --git a/drivers/staging/erofs/lz4defs.h b/drivers/staging/erofs/lz4defs.h > > index 00a0b58a0871..bdb1022981d8 100644 > > --- a/drivers/staging/erofs/lz4defs.h > > +++ b/drivers/staging/erofs/lz4defs.h > > @@ -1,32 +1,13 @@ > > #ifndef __LZ4DEFS_H__ > > #define __LZ4DEFS_H__ > > > > +// SPDX-License-Identifier: BSD-2-Clause > > For *.h files, it seems SPDX Identifier should be /* SPDX-License-Identifier: */ > rather than // SPDX-License-Identifier: That is correct. > And I think it should be placed at the first line of the line, but I am not sure of that. Yes, it has to be the first line. The documentation for the SPDX lines in the kernel describe all of this. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
