Re: [PATCH v3 04/13] staging: comedi: ni_routing: Add NI signal routing info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/10/18 03:24, Spencer E. Olson wrote:
See README for a thorough discussion of this content.

Adds tables of all register values for routing various signals to various
terminals on National Instruments hardware.  This information is directly
compared to and taken from register-level programming documentation and/or
register-level programming examples as provided by National Instruments.

Furthermore, this information was mostly compared (favorably) to the
register values already used in the comedi drivers for NI hardware.

Adds tables of valid routes for many devices.  This information is not
consistent from device to device, nor entirely consistent within device
families.  One additional major challenge is that this information does not
seem to be obtainable in any programmatic fashion, neither through the
proprietary NIDAQmx(-base) c-libraries, nor with register level
programming, _nor_ through any documentation.  In fact, the only consistent
source of this information is through the proprietary NI-MAX software,
which currently only runs on Windows platforms.  A further challenge is
that this information cannot be exported from NI-MAX, except by screenshot.

The collection and maintenance of this information is somewhat tedious and
requires frequent re-examination and comparison of NI-MAX and/or the
NI-MHDDK documentation (register programming information) and NI-MHDDK
examples.  Tools are added with this patch to facilitate generating CSV
files from the data tables.  These CSV files can be used with a spreadsheet
program to provide better visual comparision with screenshots gathered from
NI-MAX.  Tools are also added to regenerate the data tables from CSV
content--this greatly enhances updating data tables with large changes
(such as when adding devices).

Signed-off-by: Spencer E. Olson <olsonse@xxxxxxxxx>
---

Patch revisions:
   - [PATCH v3 04/13]: Minor update in indentation for support tool.

   - [PATCH v2 04/13]: Add routing information for PXIe-6535 and PXIe-6738
     devices.
   - [PATCH v2 04/13]: Implements Ian's suggestion to break up components of new
     ni_routing module into multiple compile units so that .c files are not
     included from .c files.
   - [PATCH v2 04/13]: Fixes various function prototypes and "const" variable
     declarations as per Ian's suggestions.

I'm not sure if this is a glitch in my email copy of the patch, but I got a "trailing whitespace error" on one line when applying this patch with "git am":

Applying: staging: comedi: ni_routing: Add NI signal routing info
.git/rebase-apply/patch:8112: trailing whitespace.
				NI_CtrGate(0),
warning: 1 line adds whitespace errors.

When looking at line 8212 of "drivers/staging/comedi/drivers/ni_routing/ni_device_routes/pci-6254.c", the line was terminated by CRLF instead of LF (which also caused checkpath.pl to complain about "DOS line endings"). It wasn't there in the previous patch series, and there is no reason for it to have appeared in this patch series, which is why I'm suspecting an email receiving glitch at my end.

--
-=( Ian Abbott <abbotti@xxxxxxxxx> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux