On 27/09/18 20:27, Spencer E. Olson wrote:
This patch set is the second revision of a recent patch set of the same name.
Changes and notes:
- [PATCH v2 02/13]: Update signal/terminal names found after adding additional
devices to routing list in [PATCH v2 04/13].
- [PATCH v2 04/13]: Add routing information for PXIe-6535 and PXIe-6738
devices.
- [PATCH v2 04/13]: Implements Ian's suggestion to break up components of new
ni_routing module into multiple compile units so that .c files are not
included from .c files.
- [PATCH v2 04/13]: Fixes various function prototypes and "const" variable
declarations as per Ian's suggestions.
- [PATCH v2 05/13]: Tweak Makefile to build routing info for newly added
hardware in updates to [PATCH v2 04/13].
- [PATCH v2 05/13]: Fixes placement of "select COMEDI_NI_ROUTING" to ensure
ni_routing module is enabled for all dependent modules.
- [PATCH v2 05/13]: Removes a few inline function declarations in unit test.
- [PATCH v2 07/13]: This patch must be built upon an earlier patch recently
submitted and in the queue for integration:
"staging: comedi: ni_mio_common: protect register write overflow"
I noted a minor line indentation problem detected by checkpatch.pl in my
reply to patch 04. (There are various other checkpatch.pl 'CHECK' level
issues that I'm not that bothered about.)
I also noted a cleanup for the 'bsearch' callbacks in my reply to patch 05.
Overall, I think it's very close to acceptable (from a commit point of
view I mean).
--
-=( Ian Abbott <abbotti@xxxxxxxxx> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
