On Thu, Sep 27, 2018 at 09:10:57PM +0530, Nishad Kamdar wrote: > This patch removes #if 0 code blocks and usages of the > functions defined in the #if 0 code block. It removes > the macro msdc_irq_restore() and replaces its usage > with call to the function called in the macro definition. > Issue found by checkpatch. When you have to start listing all of the different things your patch does, that's a huge hint it needs to be broken up into smaller pieces. Please make this a patch series, only doing on "logical" change at a time. You are doing too many different things here all at once. thanks greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel