Re: [PATCH 05/13] staging: comedi: add interface to ni routing table information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



How about making it selected based on COMEDI_NI_TIO?  This will impact
all the *mio* (except ATMIO16D) and 660x drivers.  This seems to be
everything that fits into the e-series, m-series, and 660x series
devices for which we know the register values.  It also doesn't look
like anything else depends on COMEDI_NI_TIO.
On Tue, Sep 25, 2018 at 4:58 AM Ian Abbott <abbotti@xxxxxxxxx> wrote:
>
> On 19/09/18 17:38, Spencer E. Olson wrote:
> > Adds interface and associated unittests for accessing/looking-up/validating
> > the new ni routing table information.
> >
> > Signed-off-by: Spencer E. Olson <olsonse@xxxxxxxxx>
> > ---
> >   drivers/staging/comedi/Kconfig                |   4 +
> >   drivers/staging/comedi/drivers/Makefile       |   1 +
> >   drivers/staging/comedi/drivers/ni_routes.c    | 523 +++++++++++++++
> >   drivers/staging/comedi/drivers/ni_routes.h    | 320 +++++++++
> >   drivers/staging/comedi/drivers/ni_stc.h       |   4 +
> >   drivers/staging/comedi/drivers/tests/Makefile |   3 +-
> >   .../comedi/drivers/tests/ni_routes_test.c     | 614 ++++++++++++++++++
> >   7 files changed, 1468 insertions(+), 1 deletion(-)
> >   create mode 100644 drivers/staging/comedi/drivers/ni_routes.c
> >   create mode 100644 drivers/staging/comedi/drivers/ni_routes.h
> >   create mode 100644 drivers/staging/comedi/drivers/tests/ni_routes_test.c
> >
> > diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
> > index 583bce9bb18e..901503c3b279 100644
> > --- a/drivers/staging/comedi/Kconfig
> > +++ b/drivers/staging/comedi/Kconfig
> > @@ -1097,6 +1097,7 @@ config COMEDI_NI_TIOCMD
> >       depends on HAS_DMA
> >       select COMEDI_NI_TIO
> >       select COMEDI_MITE
> > +     select COMEDI_NI_ROUTES
>
> This 'select COMEDI_NI_ROUTES' may be in the wrong place.  If you
> disable the COMEDI_NI_PCIMIO and COMEDI_NI_660X options, but enable the
> COMEDI_NI_ATMIO option (in the COMEDI_ISA_DRIVERS menu) and/or the
> COMEDI_NI_MIO_CS option (in the COMEDI_PCMCIA_DRIVERS menu) then the
> build breaks for the "ni_atmio" and/or "ni_mio_cs" modules.
>
> --
> -=( Ian Abbott <abbotti@xxxxxxxxx> || Web: www.mev.co.uk )=-
> -=( MEV Ltd. is a company registered in England & Wales. )=-
> -=( Registered number: 02862268.  Registered address:    )=-
> -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux