On Thu, Mar 03, 2011 at 09:16:29PM +0000, KY Srinivasan wrote: > > > > -----Original Message----- > > From: Greg KH [mailto:gregkh@xxxxxxx] > > Sent: Thursday, March 03, 2011 1:10 AM > > To: KY Srinivasan > > Cc: Greg KH; linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; > > virtualization@xxxxxxxxxxxxxx; Haiyang Zhang; Hank Janssen > > Subject: Re: [PATCH 4/6] Staging: hv: Unify the hyperv driver abstractions > > > > On Thu, Mar 03, 2011 at 02:50:00AM +0000, KY Srinivasan wrote: > > > > > > "struct driver_context"? Oh please no. > > > > > > > > > > Greg; this is the patch that consolidates the state in struct hv_driver into > > > > > struct driver_context. In the spirit of doing one thing in a patch; > > > > > other relevant changes are made in: > > > > > Patch[5/6]: Changes the name driver_context to hyperv_driver > > > > > Patch[6/6]: Cleanup all variable names that refer to struct hyperv_driver. > > > > > > > > Yes, but on its own, this patch is wrong, that is not a valid name, even > > > > if it is a "temporary" name. > > > > > > Greg, the temporary name happens to be the name currently in use in the > > > code - this is not the name I introduced. > > > > There is not a "struct driver_context" in the code that I see today, or > > am I missing something? That's my objection here, please don't use that > > name, it's not valid for a subsystem to use, even for a tiny bit. > > Look at the file vmbus.h you will see struct driver_context. This has > been there for as long as I have seen this code. Ok, I am rightly corrected, I totally missed that, you are right. Feel free to resend after addressing the other issues. I'll fix up the hv_mouse driver, you don't have to worry about that one if you don't want to, just ignore it please. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
