On 09/12/2018 10:25 PM, Dan Carpenter wrote:
On Wed, Sep 12, 2018 at 10:05:26PM +0800, cgxu519 wrote:
On 09/12/2018 05:16 PM, Dan Carpenter wrote:
On Wed, Sep 12, 2018 at 01:10:31PM +0800, Chengguang Xu wrote:
Set fault rate to 0 is useless and confusable, so add check to
avoid it.
I would have assumed setting rate to zero just disabled it.
I think currently it is useless because we have not implemented
option parsing in remount yet, maybe it's better adding another
option 'no_fault_injection' to explicitly disable it.
That's like the AC on my car, where I can't turn the fan from one to
zero, I have to press disable. I don't like the explicit disable, I
wish they would just remove that button.
Interesting, It seems same logic everywhere...
But I also don't think most people will ever use the fault injection
interface so it doesn't really matter. Do whatever seems good to you.
More background:
The main reason I touch this option is in remount sometimes
we need to restore original option setting when we detecting error
during option parsing, so after this patch we can easily determine
the option is explicitly set or just keep default value.
Thanks,
Chengguang
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
