Re: [PATCH v2] staging: android: ion: Add per-heap counters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 11, 2018 at 11:50:19AM +0300, Dan Carpenter wrote:
> On Tue, Sep 11, 2018 at 11:17:10AM +0300, Alexey Skidanov wrote:
> > @@ -546,6 +556,38 @@ void ion_device_add_heap(struct ion_heap *heap)
> >  	}
> >  
> >  	heap->dev = dev;
> > +	heap->num_of_buffers = 0;
> > +	heap->num_of_alloc_bytes = 0;
> > +	heap->alloc_bytes_wm = 0;
> > +
> > +	/* Create heap root directory. If creation is failed, we may continue */
> > +	heap_root = debugfs_create_dir(heap->name, dev->debug_root);
> > +	if (!IS_ERR_OR_NULL(heap_root)) {
> 
> Just remove this check.  If debugfs_create_dir() fails, it doesn't
> cause any problems here.

I asked for that to be done last time :(

{sigh}

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux