Re: [PATCH] staging: android: ion: Add per-heap counters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 10, 2018 at 01:46:13PM +0300, Alexey Skidanov wrote:
> 
> 
> On 09/10/2018 11:27 AM, Greg KH wrote:
> > On Sun, Sep 09, 2018 at 01:44:31AM +0300, Alexey Skidanov wrote:
> >> The heap statistics have been removed and currently even basics statistics
> >> are missing.
> >>
> >> This patch creates per heap debugfs directory /sys/kernel/debug/<heap_name>
> >> and adds two counters - the number of allocated buffers and number of
> >> allocated bytes.
> > 
> > Why?  What can we do with this information?
> Are you in doubt that we need these two specific counters or debugfs at all?

These specific counters.  What are you going to do with them?

And you also moved debugfs files (you didn't comment on that comment),
which will probably break tools that expect the files to be in one
place, right?  How did you test this patch?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux