[PATCH v2 00/26] staging: wilc1000: avoid use of static and global variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch set mainly contains changes to avoid the use of static
and global variables. Also contains few patch to avoid the checkpatch
warning arise due to code refactor.

Changes since v1:
 1. rework on patch#10, use dynamically allocating memory to maintain
    multicast mac address filter list.
 2. rework on patch#11, only move hif_workqueue to 'wilc' struct.
 3. dropped patch#12 of previous patchset version.
 4. modified patch#18 & #19 as per the review comments.
 5. patch#22, change 'int' to 'bool' type for 'connecting' variable.
 6. added 3 new patches #24,25 &26 in this series.


Ajay Singh (26):
  staging: wilc1000: move 'wilc_enable_ps' global variable into 'wilc'
    struct
  staging: wilc1000: move 'aging_timer' static variable to wilc_priv
    struct
  staging: wilc1000: fix to use correct index to free scanned info in
    clear_shadow_scan()
  staging: wilc1000: remove unnecessary NULL check in
    clear_shadow_scan()
  staging: wilc1000: moved last_scanned_shadow & last_scanned_cnt to
    wilc_priv struct
  staging: wilc1000: move during_ip_timer & wilc_optaining_ip to
    'wilc_vif' struct
  staging: wilc1000: remove unused variable 'op_ifcs'
  staging: wilc1000: avoid use of extra 'if' condition in wilc_init()
  staging: wilc1000: move static variable clients_count to 'wilc'
    structure
  staging: wilc1000: refactor code to avoid use of
    wilc_set_multicast_list global
  staging: wilc1000: move hif_workqueue static variables to 'wilc'
    structure
  staging: wilc1000: move 'periodic_rssi' as part of 'wilc_vif' struct
  staging: wilc1000: rename 'dummy_statistics' variable to
    'periodic_stat'
  staging: wilc1000: move 'rcv_assoc_resp' as part of hif_drv
  staging: wilc1000: refactor tcp_process() to avoid extra leading tabs
  staging: wilc1000: use lowercase for get_BSSID() and HIL variable
  staging: wilc1000: move tcp_ack_filter algo related variables to
    'wilc_vif' struct
  staging: wilc1000: avoid line over 80 chars in
    wilc_wlan_txq_filter_dup_tcp_ack()
  staging: wilc1000: use short names to fix over 80 issue in
    tcp_process()
  staging: wilc1000: remove unused code to set and get IP address
  staging: wilc1000: move 'chip_ps_state' static variable as part of
    'wilc' struct
  staging: wilc1000: move 'wilc_connecting' static variable to
    'wilc_vif' struct
  staging: wilc1000: remove unnecessary static variable
    'p2p_listen_state'
  staging: wilc1000: refactor code to move initilization in
    wilc_netdev_init()
  staging: wilc1000: refactor wilc_netdev_init() to handle memory free
    in error path
  staging: wilc1000: remove handle_hif_exit_work() function

 drivers/staging/wilc1000/coreconfigurator.c       |   4 +-
 drivers/staging/wilc1000/host_interface.c         | 215 ++++------------------
 drivers/staging/wilc1000/host_interface.h         |  13 +-
 drivers/staging/wilc1000/linux_wlan.c             |  79 +++++---
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 197 ++++++++++----------
 drivers/staging/wilc1000/wilc_wfi_netdevice.h     |  41 ++++-
 drivers/staging/wilc1000/wilc_wlan.c              | 174 ++++++++---------
 drivers/staging/wilc1000/wilc_wlan.h              |   5 +-
 8 files changed, 307 insertions(+), 421 deletions(-)

-- 
2.7.4

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux