Re: [PATCH 2/7] Staging: vt6656: Use C89 comments in power.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 02, 2011 at 06:10:56PM +0300, Dan Carpenter wrote:
> On Wed, Mar 02, 2011 at 02:34:40PM +0000, Philip Worrall wrote:
> > -/*+
> > +/*
> >   *
> 
> The blank line isn't needed here.
> 
> >   * Routine Description:
> >   * Enable hw power saving functions
> > @@ -68,7 +68,7 @@ static int msglevel = MSG_LEVEL_INFO;
> >   * Return Value:
> >   *    None.
> >   *
> 
> Or here.
> 

Actually, it would be even better to write these in kernel-doc format.
See Documentation/kernel-doc-nano-HOWTO.txt

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux