Re: [PATCH 6/7] Staging: vt6656: Simplify setting of power state in frame header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 02, 2011 at 02:34:44PM +0000, Philip Worrall wrote:
> --- a/drivers/staging/vt6656/power.c
> +++ b/drivers/staging/vt6656/power.c
> @@ -274,6 +274,7 @@ BOOL PSbSendNullPacket(void *hDeviceContext)
>  	PSDevice pDevice = (PSDevice)hDeviceContext;
>  	PSTxMgmtPacket pTxPacket = NULL;
>  	PSMgmtObject pMgmt = &(pDevice->sMgmtObj);
> +	__u16 flags = 0;

__u16 is only for header files which get used by userspace.  u16 would
be better here.  I don't think this is worth resending, I'm just
pointing it out for next time.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux