On Wed, Aug 29, 2018 at 02:39:30PM +0300, Dan Carpenter wrote:
> On Tue, Aug 28, 2018 at 08:26:22PM +0100, Tim Collier wrote:
> > Remove braces from an if statement with only a single line in the if
> > block.
> >
> > Signed-off-by: Tim Collier <osdevtc@xxxxxxxxx>
> > ---
> > drivers/staging/wlan-ng/hfa384x_usb.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> > index 6261881e9bcd..4824b37b27a3 100644
> > --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> > +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> > @@ -3623,10 +3623,9 @@ static void hfa384x_usbout_callback(struct urb *urb)
> > struct hfa384x *hw = wlandev->priv;
> >
> > if (!test_and_set_bit(THROTTLE_TX, &hw->usb_flags) &&
> > - !timer_pending(&hw->throttle)) {
> > + !timer_pending(&hw->throttle))
> > mod_timer(&hw->throttle,
> > jiffies + THROTTLE_JIFFIES);
> > - }
>
> This is fine either way. We sort of prefer the original style because
> it's more readable. Multi-line indents get curly braces.
Ok, I will drop this from v2. Thanks Dan.
>
> regards,
> dan carpenter
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
