On Mon, Aug 27, 2018 at 10:58:48PM -0500, Luke Cesarz wrote:
> This patch corrects the lines extending over 80 characters, fixing the
> checkpatch.pl warnings in rf69.c: 'WARNING: line over 80 characters'
>
> Signed-off-by: Luke Cesarz <lucesarz@xxxxxxxxx>
> ---
> drivers/staging/pi433/rf69.c | 103 ++++++++++++++++++++++-------------
> 1 file changed, 64 insertions(+), 39 deletions(-)
>
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index 085272fb393f..be3be9214198 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -185,21 +185,25 @@ int rf69_set_modulation_shaping(struct spi_device *spi,
> case FSK:
> switch (mod_shaping) {
> case SHAPING_OFF:
> - return rf69_read_mod_write(spi, REG_DATAMODUL,
> - MASK_DATAMODUL_MODULATION_SHAPE,
> - DATAMODUL_MODULATION_SHAPE_NONE);
> + return rf69_read_mod_write(
> + spi, REG_DATAMODUL,
> + MASK_DATAMODUL_MODULATION_SHAPE,
> + DATAMODUL_MODULATION_SHAPE_NONE);
Ick, no, the original code here is just fine, please leave it as-is.
checkpatch is a hint, not a hard rule.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
