Hi Adham, On Fri, 24 Aug 2018 17:32:46 -0700 Adham Abozaeid <adham.abozaeid@xxxxxxxxxxxxx> wrote: > On Fri, 24 Aug 2018 11:47:14 +0300 > Claudiu Beznea <Claudiu.Beznea@xxxxxxxxxxxxx> wrote: > > > > > > > On 23.08.2018 13:00, Ajay Singh wrote: > > > Unless ndo_set_rx_mode() gets called quickly I don't think there > > > is any issue here. > > > > I don't agree with this. > > It would be safer that the mcast list be passed to > wilc_setup_multicast_filter() to be copied to the msg structure then > handled by the worker thread. In this case vif->mc_mac_addr_list can > be removed all together. Thanks for your suggestion. Yes, I agree we can allocate and pass 'mac_addr_list' to worker thread so it can be handled safely. And this solution would be better than changing handle_set_mcast_filter() to a sync call, which i have suggested earlier. Regards, Ajay _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel