On Tue, Mar 01, 2011 at 02:44:37PM +0100, Arend van Spriel wrote: > On Tue, 01 Mar 2011 14:26:18 +0100, Dan Carpenter > <error27@xxxxxxxxx> wrote: > > >On Tue, Mar 01, 2011 at 10:56:58AM +0100, Arend van Spriel wrote: > >>wlc_mac80211 has been renamed to wlc_main. This commit makes the > >>required changes to the other driver files to make it compile again. > >> > > > >It would have been better to combine this one with 4/6 so that the > >code compiles after every commit. Otherwise it breaks git bisect. > > > > I thought I followed your guideline in splitting them. > Quoting:"" > I know that we say you should run checkpatch on all patches, but moving > code around is the exception. If it had just moved the code around > without the changes, then we have automated ways of reviewing that. > "" Moving stuff around in a patch and keeping it separate is great, but you can not override the most important rule here, NEVER BREAK THE BUILD! thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
