On Fri, Aug 24, 2018 at 11:06:56PM +0200, Sven Luthi wrote:
> Checkpatch repored "Lines should not end with a '('" for line 1283.
>
> Moved opening parenthesis of function on line 1283 onto next line.
>
> Signed-off-by: Sven Luthi <dev@xxxxxxxxxxxxx>
> ---
> drivers/staging/comedi/drivers/adl_pci9118.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c
> index 2528ca0ede6d..07431dc9cde9 100644
> --- a/drivers/staging/comedi/drivers/adl_pci9118.c
> +++ b/drivers/staging/comedi/drivers/adl_pci9118.c
> @@ -1280,8 +1280,8 @@ static int pci9118_ai_cmdtest(struct comedi_device *dev,
> } else {
> arg = cmd->convert_arg * cmd->chanlist_len;
> }
> - err |= comedi_check_trigger_arg_min(
> - &cmd->scan_begin_arg, arg);
> + err |= comedi_check_trigger_arg_min
> + (&cmd->scan_begin_arg, arg);
The original is fine. It's probably better than the new version.
Checkpatch.pl is just a hint, not a command.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
