On Wed, Aug 22, 2018 at 02:38:44PM +0300, Dan Carpenter wrote:
> On Wed, Aug 22, 2018 at 04:40:56PM +0530, Nishad Kamdar wrote:
> > On Wed, Aug 22, 2018 at 12:09:36PM +0300, Dan Carpenter wrote:
> > > On Wed, Aug 22, 2018 at 02:04:55PM +0530, Nishad Kamdar wrote:
> > > > This patch fixes the debug macro N_MSG. Replaces printk with
> > > > dev_<level> without __func__ or __LINE__ or current->comm and
> > > > current->pid. Removes the do {} while(0) loop for the single
> > > > statement macro. Issue found by checkpatch.
> > > >
> > > > Signed-off-by: Nishad Kamdar <nishadkamdar@xxxxxxxxx>
> > > > ---
> > > > drivers/staging/mt7621-mmc/dbg.h | 11 ++++-------
> > > > 1 file changed, 4 insertions(+), 7 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/mt7621-mmc/dbg.h b/drivers/staging/mt7621-mmc/dbg.h
> > > > index 2f2c56b73987..c56fb896617a 100644
> > > > --- a/drivers/staging/mt7621-mmc/dbg.h
> > > > +++ b/drivers/staging/mt7621-mmc/dbg.h
> > > > @@ -104,13 +104,10 @@ do { \
> > > >
> > > > #define N_MSG(evt, fmt, args...)
> > > > /*
> > > > -do { \
> > > > - if ((DBG_EVT_##evt) & sd_debug_zone[host->id]) { \
> > > > - printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \
> > > > - host->id, ##args , __FUNCTION__, __LINE__, current->comm, current->pid); \
> > > > - } \
> > > > -} while(0)
> > > > -*/
> > > > + *if ((DBG_EVT_##evt) & sd_debug_zone[host->id]) { \
> > > > + * dev_err(mmc_dev(host->mmc), "%d -> " fmt "\n", host->id, ##args) \
> > > > + *}
> > > > + */
> > >
> > > I don't understand what you're trying to do here. You just commented
> > > out the macro and turned it into a no-op. That's not what the patch
> > > description says.
> > >
> > > To me the original code seems fine.
> > >
> > > regards,
> > > dan carpenter
> > >
> >
> > Ok. But the macro definition was already commented.
> > I just changed printk to dev_err and gave it a better
> > block comment format.
> > Should I leave the older version as it is ?
>
> Oh... Yeah. You're right. Sorry about that.
>
> We normally just delete dead code without even thinking hard about it.
> It turns out that if we delete all the N_MSG() code, it's actually quite
> a bit. But probably it's the right thing to do, instead of hanging on
> to it like a hoarder.
>
> regards,
> dan carpenter
>
Ok. I get it.
Thanks for the review.
regards,
nishad
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
