On Mon, Aug 20, 2018 at 3:33 AM, NeilBrown <neil@xxxxxxxxxx> wrote:
> On Sun, Aug 12 2018, Sergio Paracuellos wrote:
>
>> This patch series parse remaining port info from device tree storing
>> it in mt7621_pcie_port struct created for this.
>>
>> Also minor cleanups are performed here:
>> - Remove not used macros.
>> - Use kernel reset_control functions.
>> - Remove unused code.
>>
>> Changes in v2:
>> - Rewrite phy part of the driver
>> - fix some checkpatch complains
>> - make use of sysctl from DT
>>
>> Hope this helps.
>
> Unfortunately commit f8c55dc6e828324fc58c0bb32d72a5a4041d1c3b
> broke DMA on the mt7621, so I cannot test anything since then.
>
> I apply these patches onto
> 4cafd03a916e2f7c15520fed0b7894cf25f4ecc5
> and get
>
> [ 0.570000] mt7621-pci 1e140000.pcie: missing "reg" property
> [ 0.580000] mt7621-pci 1e140000.pcie: Parsing DT failed
> [ 0.590000] mt7621-pci: probe of 1e140000.pcie failed with error -22
>
> and no working PCI.
Thanks for your time Neil and sorry for my late response. My bad here,
I was trying to get
reg stuff from child nodes instead of its parent to properly get those
from device tree.
I'll redo this taking also into account Dan's comments and send v3
hopefully during this week.
>
> Thanks,
> NeilBrown
>
Best regards,
Sergio Paracuellos
>
>>
>> Best regards,
>> Sergio Paracuellos
>>
>> Sergio Paracuellos (20):
>> staging: mt7621-pci: parse and init port data from device tree
>> staging: mt7621-pci: replace return value if
>> devm_pci_alloc_host_bridge call fails
>> staging: mt7621-pci: add two helpers for read and write pcie register
>> ports
>> staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function
>> staging: mt7621-pci: remove [ASSERT|DEASSERT]_SYSRST_PCIE macros
>> staging: mt7621-pci: remove GPL2+ text from license header
>> staging: mt7621-pci: remove two commented code lines
>> staging: mt7621-pci: remove reset related unused macros
>> staging: mt7621-pci: reagroup reset related macros all together
>> staging: mt7621-pci: make some function static
>> staging: mt7621-pci: show N_FTS status using a loop
>> staging: mt7621-pci: rewrite pcie phy related functions
>> staging: mt7621-pci: factor out 'mt7621_enable_phy' function
>> staging: mt7621-pci: debug port N_FTS inside 'mt7621_pcie_enable_port'
>> staging: mt7621-pci: rename 'mt7621_pcie_enable_port' into
>> 'mt7621_pcie_init_port'
>> staging: mt7621-dts: add sysctl registers base address to pcie
>> staging: mt7621-pci: remap and use sysctl from device tree
>> staging: mt7621-pci: use a trailing */ on a separate line
>> staging: mt7621-pci: use dev_* functions instead of printk
>> staging: mt7621-pci: do not initialise statics to 0
>>
>> drivers/staging/mt7621-dts/mt7621.dtsi | 4 +-
>> drivers/staging/mt7621-pci/pci-mt7621.c | 600 ++++++++++++++++++++------------
>> 2 files changed, 381 insertions(+), 223 deletions(-)
>>
>> --
>> 2.7.4
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
