Re: [staging-next 1/5] staging/easycap: add first level indentation to easycap_main

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 28, 2011 at 07:27:06PM +0200, Tomas Winkler wrote:
> Add first level indentation to easayca_main.c
> This created around 300 lines over 80 characters.
> Around 100 of straight forward once were fixed in this patch.
> The another 200 require more code movement and need to be fixed
> later
> 

For this kind of patch it's better to ignore the over 80 char warnings
and send the fixes for that in a separate patch.

I've reviewed all five patches and I didn't see any bugs.  Some of the
JOM() and SAM() messages and normally that kind of thing should be 
mentioned in the changelog, but those were small changes so *shrug*.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux