Re: [patch] Staging: generic_serial: fix double locking bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 28, 2011 at 10:28:31PM +0300, Dan Carpenter wrote:
> spin_lock_irqsave() is not nestable.  The second time that it gets
> called it overwrites the "flags" variable and so IRQs can't be restored
> properly.
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> ---
> Oh.  Crap.  I don't want to adopt these drivers.  But I already wrote
> the patch before I read the TODO file, so I'm still going to submit it.

Heh, don't worry, you don't "own" them, I'll just take this fix for now
and still leave them in the "abandoned" category :)

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux