Re: [PATCH 1/2] staging: fix possible_condition_with_no_effect warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/05/2018 02:35 PM, Umang Parmar wrote:
Remove unnecessary conditions where if and else block had same code.
Signed-off-by: Umang Parmar <umangjparmar@xxxxxxxxx>

The subject should be "staging: rtlwifi: ...". If someone wants to search for fixes to the modules in drivers/staging/rtlwifi/, your subject would not be helpful.
---
  .../rtlwifi/btcoexist/halbtc8822b2ant.c       |  6 ----
  .../staging/rtlwifi/btcoexist/halbtcoutsrc.c  |  6 ++--
  drivers/staging/rtlwifi/phydm/phydm_debug.c   | 29 ++++++-------------
  drivers/staging/rtlwifi/phydm/phydm_dig.c     | 10 ++-----
  .../staging/rtlwifi/phydm/phydm_hwconfig.c    |  4 +--
  drivers/staging/rtlwifi/phydm/phydm_psd.c     |  7 +----
  6 files changed, 16 insertions(+), 46 deletions(-)

Why do some of the above have "drivers/staging/..." and others have ".../staging/..."? This looks a bit strange.

Otherwise, this patch looks OK.

Larry
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux