On Mon, Jul 30, 2018 at 11:11:38AM +0200, Greg KH wrote: > On Sun, Jul 29, 2018 at 10:07:33PM +0100, John Whitmore wrote: > > Remove the typedef of the structure cmpk_txfb_t. This clears the > > checkpatch issue with defining new types. > > > > Additionally the type is renamed from cmpk_txfb_t to cmd_pkt_tx_feedback > > removing the '_t' as the typedef has been removed. > > > > These changes are purely coding style in nature and should have no > > impact on runtime code execution. > > > > Signed-off-by: John Whitmore <johnfwhitmore@xxxxxxxxx> > > --- > > drivers/staging/rtl8192u/r819xU_cmdpkt.c | 8 ++++---- > > drivers/staging/rtl8192u/r819xU_cmdpkt.h | 6 +++--- > > 2 files changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/staging/rtl8192u/r819xU_cmdpkt.c > > index 3140b3413f91..630cf612f265 100644 > > --- a/drivers/staging/rtl8192u/r819xU_cmdpkt.c > > +++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.c > > @@ -66,7 +66,7 @@ rt_status SendTxCommandPacket(struct net_device *dev, void *pData, u32 DataLen) > > * Overview: > > * > > * Input: PADAPTER pAdapter > > - * CMPK_TXFB_T *psTx_FB > > + * STRUCT CMD_PKT_TX_FEEDBACK *psTx_FB > > nit, this should all be in lowercase now right? > > Anyway, these function comments need to all go anyway, they are horrid :) > > Something for future patches, look at the ones for the gasket driver > sent yesterday as an example of what to do. > > thanks, > > greg k-h Thanks for the pointer to gasket driver. I didn't like to start into horrid comments, thinking that maybe they do convey some information to somebody, or they're in that format for a reson. The code is easier. Anyhow thanks for that pointer, and I will change comments in future. Sure all that can happen is you'll reject some/all, but sure I might learn the style required. jwhitmore _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
