Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 30, 2018 at 10:58 AM, Greg KH <greg@xxxxxxxxx> wrote:
> On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote:
>> Fix several sparse warnings regarding different address space
>> assignments, like example below, by properly annotating pointers
>> expected to carry user space addresses.
>>
>> warning: incorrect type in argument 1 (different address spaces)
>> Signed-off-by: Carlos Maiolino <cmaiolino28@xxxxxxxxx>
>> ---
>
> We need a blank line befor your signed-off-by line please.
>

Thanks, I'll resend, or do you prefer me to way until this get a review from
the maintainer, and I resend the fixed description with the reviewed-by?


>> +     const struct vchiq_element __user *elements;
>>  } VCHIQ_QUEUE_MESSAGE_T;
>>
>>  typedef struct {
>
> It would be great to have an ack from the maintainers here :)
>
> thanks,
>
> greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux