This series of patches contain purely simple coding style changes. I considered renaming the struct cmpk_set_cfg_t as it is never actually used. Following its definition however it is used in a #define: #define cmpk_query_cfg_t cmpk_set_cfg_t So whilst the struct cmpk_set_cfg_t is never used, cmpk_query_cfg_t is. I left it because the comments described this. I was also tempted to remove comments at the end of lines pushing the lines over 80 character length. The comments are at the end of sizeof operators which explicitly state the size. I'm not sure much is gained by the comment, but I left them in: #define ... sizeof(struct cmpk_txfb_t) /* 20 */ #define ... sizeof(struct cmpk_set_cfg_t) /* 16 */ *** BLURB HERE *** John Whitmore (10): staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style staging:rtl8192u: Remove unused CMPK_TX_SET_CONFIG_SIZE - Style staging:rtl8192u: Rename bit definition ISR_TxBcnOk - Style staging:rtl8192u: Removed unused CMPK_RX_DBG_MSG_SIZE - Style staging:rtl8192u: Rename ISR_TxBcnErr bit definition - Style staging:rtl8192u: Rename ISR_BcnTimerIntr - Style staging:rtl8192u: Remove multiple blank lines - Style staging:rtl8192u: Correct spelling in comments - style staging:rtl8192u: Remove typedef of struct cmpk_intr_sta_t - Style staging:rtl8192u: Remove typedef from struct cmpk_set_cfg_t - Style drivers/staging/rtl8192u/r819xU_cmdpkt.c | 22 ++++++++--------- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 31 ++++++++++-------------- 2 files changed, 24 insertions(+), 29 deletions(-) -- 2.18.0 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel