On Fri, Feb 25, 2011 at 11:31:36AM +0100, Arend van Spriel wrote:
> The functions within wlc_alloc had parameter of struct osl_info type
> but it was never used. As part of osl concept removal this parameter
> has been removed from the function prototypes.
>
When memory allocations fail it generates a stack dump unless you
use GFP_NOWARN. So really nothing would be lost if you just defined
wlc_alloc() like this:
void *wlc_calloc(size_t size)
{
return kzalloc(size, GFP_ATOMIC);
}
Also it's weird to call the function "wlc_calloc" when it's not simillar
to calloc() at all. Anyway, that's just a comment. The patch here is
fine.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
