On Fri, Feb 25, 2011 at 11:31:27AM +0100, Arend van Spriel wrote: > The source and include file for the wlc_mac80211 module has been > renamed to wlc_main and subsequently the include statement in > other source files. This module provides the main interface towards > wl_mac80211 module. > I know that we say you should run checkpatch on all patches, but moving code around is the exception. If it had just moved the code around without the changes, then we have automated ways of reviewing that. This patch is 20k lines long. Ideally it would have been several patches. One to move the code without changes. It would be a big patch to fast to review automatically. One to fix checkpatch warnings. One to add comments. I'm not going to say that you should redo it, but please don't do it this way next time. Reviewed-by: Dan Carpenter <error27@xxxxxxxxx> regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
