On Sun, Jul 22, 2018 at 12:50:25AM -0700, Joe Perches wrote: > On Sun, 2018-07-22 at 09:39 +0530, Nishad Kamdar wrote: > > Bring the first argument to the previous line and > > align the other lines to match open parenthesis. > [] > > diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c > [] > > @@ -883,10 +883,9 @@ static int dgnc_tty_open(struct tty_struct *tty, struct file *file) > > * touched safely, the close routine will signal the > > * ch_flags_wait to wake us back up. > > */ > > - rc = wait_event_interruptible( > > - ch->ch_flags_wait, > > - (((ch->ch_tun.un_flags | > > - ch->ch_pun.un_flags) & UN_CLOSING) == 0)); > > + rc = wait_event_interruptible(ch->ch_flags_wait, > > + (((ch->ch_tun.un_flags | > > + ch->ch_pun.un_flags) & UN_CLOSING) == 0)); > > > This would be better without the superfluous () and perhaps use ! > > rc = wait_event_interruptible(ch->ch_flags_wait, > !((ch->ch_tun.un_flags | > ch->ch_pun.un_flags) & UN_CLOSING)); > > Ok, I will revise the patch. Thanks for the review. regards, nishad kamdar _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
