I'm getting some compile warnings where we us %u instead of %lu for size_t. We also need a README explaining what else needs to be done before this can be moved out of staging into the normal part of the kernel. On Wed, Jul 18, 2018 at 10:46:34PM -0400, Jacob Feder wrote: > I hope I did the Makefile/Kconfig corretly :) > > Thanks for all the feedback. > > Cheers, > Jacob > These sorts of meta commentary go under the --- cut off line > This IP core has read and write AXI-Stream FIFOs, the contents of which can > be accessed from the AXI4 memory-mapped interface. This is useful for > transferring data from a processor into the FPGA fabric. The driver creates > a character device that can be read/written to with standard > open/read/write/close. > > See Xilinx PG080 document for IP details. > > https://www.xilinx.com/support/documentation/ip_documentation/axi_fifo_mm_s/v4_1/pg080-axi-fifo-mm-s.pdf > > The driver currently supports only store-forward mode with a 32-bit > AXI4 Lite interface. DOES NOT support: > - cut-through mode > - AXI4 (non-lite) ^^^^^^^^^^^^^^ This kind of information is useful, but it's not really a requirement for being removed out of staging. The code quality is OK to me generally, but I'm not qualified to talk about big picture user API stuff or very subsystem specific requirements. > > Signed-off-by: Jacob Feder <jacobsfeder@xxxxxxxxx> > --- ^^^ Here is the cut off line. That way they aren't added to the kernel git log. > drivers/staging/axisfifo/Kconfig | 9 + > drivers/staging/axisfifo/Makefile | 1 + > drivers/staging/axisfifo/axis-fifo.c | 1125 +++++++++++++++++++++++++++++++++ > drivers/staging/axisfifo/axisfifo.txt | 89 +++ > 4 files changed, 1224 insertions(+) > create mode 100644 drivers/staging/axisfifo/Kconfig > create mode 100644 drivers/staging/axisfifo/Makefile > create mode 100644 drivers/staging/axisfifo/axis-fifo.c > create mode 100644 drivers/staging/axisfifo/axisfifo.txt > > diff --git a/drivers/staging/axisfifo/Kconfig b/drivers/staging/axisfifo/Kconfig > new file mode 100644 > index 0000000..5ad68bf > --- /dev/null > +++ b/drivers/staging/axisfifo/Kconfig > @@ -0,0 +1,9 @@ > +# > +# "Xilinx AXI-Stream FIFO IP core driver" > +# > +config XIL_AXISFIFO > + tristate "Xilinx AXI-Stream FIFO IP core driver" > + default n > + help > + This adds support for the Xilinx AXI-Stream > + FIFO IP core driver. You also need to add yourself to drivers/staging/Kconfig,Makefile. Use make menuconfig to enable it and do a build. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
