Hello Dan,
Yeah. We should delete the assert statement too because that's the easiest way to get rid of the warning.
I use a little script that I wrote myself that checks a patch series before submitting it. The script builds each commit in the patch series in different configurations (eg, both for CONFIG_BRCMDBG =y and =n). It also runs a checkpatch.pl on each commit. I just modified the script to treat compiler warnings as errors, as to automatically detect this kind of stuff in the future.
Regarding 'get rid of this assert statement': ASSERTs serve a useful purpose, also this specific ASSERT instance. I would prefer to put the assert under a conditional compile flag.
Thanks for your sharp eye, Roland. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
