On Wed, Feb 23, 2011 at 04:57:29PM -0800, Joe Perches wrote: > On Wed, 2011-02-23 at 23:17 +0000, Hank Janssen wrote: > > > -----Original Message----- > > > From: Greg KH [mailto:greg@xxxxxxxxx] > > > Sent: Wednesday, February 23, 2011 1:57 PM > > > They where compile and run tested. And syslog was not a mess. What did > > > > I mess up here? The amount of printouts now are a fraction of what > > > > they where before. > > > You forgot to put '\n' at the end of all of your pr_XXX lines, so they will be > > > merged with the next one, messing up your syslog. Joe also pointed this > > > problem out. > > > Take a look at your syslog to see what I am talking about... > > Greg, there probably isn't any problem with his syslog. > > Running together of messages without terminating newlines > did used to happen though until commit > 5fd29d6ccbc98884569d6f3105aeca70858b3e0f > ("printk: clean up handling of log-levels and newlines") > changed behavior so that newlines are emitted if necessary > before every "<.>" loglevel but "<c>". > > That means that adding trailing newlines to pr_<level> > calls aren't _really_ necessary unless the pr_<level> > is followed by a bare printk without KERN_<LEVEL>. Ah, I didn't realize that this had changed, my mistake, nevermind :) > I still think it's better from a style perspective to keep > adding terminating newlines until most all of the printks > are converted to pr_<level>. Yes, that would be good to have done. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
