Re: [PATCH] staging: gasket remove current_kernel_time usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 13, 2018 at 05:06:37PM +0200, Arnd Bergmann wrote:
> A new user of the deprecated current_kernel_time() function has appeared
> here. This code won't work correct during leap seconds or a concurrent
> settimeofday() call, and it probably doesn't do what the author intended
> even for the normal case, as it passes a timeout in nanoseconds but
> reads the time using a jiffies-granularity accessor.
> 
> I'm changing it to ktime_get_ns() here, which simplifies the logic,
> and uses a high-res clocksource. This is a bit slower, but that
> probably doesn't matter in a busy-wait loop.
> 
> Note: it also doesn't matter in the current version, as there are no
> callers of this function.

Let's just rip the whole function out, I've been going through and
removing functions that no one calls and no one uses.  That would make
more sense here.  Want me to send a patch for that, or do you want to?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux