From: Dexuan Cui Sent: Thursday, July 12, 2018 10:53 PM > > Before setting channel->rescind in vmbus_rescind_cleanup(), we should make > sure the channel callback won't run any more, otherwise a high-level > driver like pci_hyperv, which may be infinitely waiting for the host VSP's > response and notices the channel has been rescinded, can't safely give > up: e.g., in hv_pci_protocol_negotiation() -> wait_for_response(), it's > unsafe to exit from wait_for_response() and proceed with the on-stack > variable "comp_pkt" popped. The issue was originally spotted by > Michael Kelley <mikelley@xxxxxxxxxxxxx>. > > In vmbus_close_internal(), the patch also minimizes the range protected by > disabling/enabling channel->callback_event: we don't really need that for > the whole function. > > Signed-off-by: Dexuan Cui <decui@xxxxxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > Cc: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > Cc: Stephen Hemminger <sthemmin@xxxxxxxxxxxxx> > Cc: Michael Kelley <mikelley@xxxxxxxxxxxxx> Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx> _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
