Re: [PATCH v2 1/2] staging: goldfish: fix whitespace in goldfish_audio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 11, 2018 at 04:36:28PM -0700, rkir@xxxxxxxxxx wrote:
> From: Roman Kiryanov <rkir@xxxxxxxxxx>
> 
> Linux kernel coding style: spaces are never used for
> indentation.

This patch is good but that's not strictly true...  I don't think the
code here causes a checkpatch.pl warning, and checkpatch is pretty on
point with regards to tabs vs spaces.

The rules are:
1) Use tabs to indent code
2) Tabs always come before spaces
3) Use spaces to make things align

So say you have an if statement:

	if (some_condition() ||
	    bar) {
		blah blah blah

The bar line is [tab][space][space][space][space]bar) {
It's the same for function parameters, you have to use spaces to make
them align.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux