Re: [PATCH 2/3] staging: mt7621-pci: use generic kernel pci subsystem read and write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 11, 2018 at 11:16:14AM +0200, Greg KH wrote:
> On Tue, Jul 10, 2018 at 09:33:47PM +0200, Sergio Paracuellos wrote:
> > map_bus callback is called before every .read/.write operation.
> > Implement it and change custom read write operations for the
> > pci subsystem generics. Make the probe function to assign data
> > for controller data and get pci register base from device tree.
> 
> Ok, now this makes a bit more sense, I should have read this before
> reviewing the first patch, sorry.

I though in send only two patches one introducing all (including the 
data struct) and the second removing dead code to avoid confusion but 
I ended up in this three. Sorry.
> 
> You have tested this out, right?  If it works, great, I'll gladly take
> this series then, it starts to make the platform a bit more sane, nice
> work.

No, I don't have the hardware to test this :-(. Let's wait for the Neil's
feedback then.

Good to hear that this is the correct way to start the cleaning properly,
thanks. 

> 
> thanks,
> 
> greg k-h

Best regards,
    Sergio Paracuellos
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux