Re: [PATCH] Staging: hv: Trivial patch to fix compile warning.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 20, 2011 at 03:58:37PM +0000, Haiyang Zhang wrote:
> > From: Javier Martinez Canillas [mailto:martinez.javier@xxxxxxxxx]
> > Sent: Saturday, February 19, 2011 4:44 PM
> > To: Greg Kroah-Hartman
> > Cc: K. Y. Srinivasan; Hank Janssen; Haiyang Zhang;
> > devel@xxxxxxxxxxxxxxxxxxxx; Javier Martinez Canillas
> > Subject: [PATCH] Staging: hv: Trivial patch to fix compile warning.
> > 
> > cn_add_callback() defines is second argument as a char * but a
> > const char * was supplied instead. So the compiler generates a
> > compile warning.
> > 
> > This trivial patch solves the issue by removing the const type
> > qualifier.
> > 
> > Signed-off-by: Javier Martinez Canillas <martinez.javier@xxxxxxxxx>
> > ---
> >  drivers/staging/hv/hv_kvp.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/staging/hv/hv_kvp.c b/drivers/staging/hv/hv_kvp.c
> > index bc1c20e..82edea2 100644
> > --- a/drivers/staging/hv/hv_kvp.c
> > +++ b/drivers/staging/hv/hv_kvp.c
> > @@ -66,7 +66,7 @@ static void kvp_register(void);
> >  static DECLARE_DELAYED_WORK(kvp_work, kvp_work_func);
> > 
> >  static struct cb_id kvp_id = { CN_KVP_IDX, CN_KVP_VAL };
> > -static const char kvp_name[] = "kvp_kernel_module";
> > +static char kvp_name[] = "kvp_kernel_module";
> 
> Thank you for fixing it.
> 
> Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>

I've applied the other patch, that changes the connector interface
instead.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux