Re: [PATCH] ANDROID: binder: Latelimit binder_debug().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018/07/09 23:02, Martijn Coenen wrote:
> On Mon, Jul 9, 2018 at 3:27 PM, Dmitry Vyukov <dvyukov@xxxxxxxxxx> wrote:
>> I know almost nothing about binder. How these debug messages are
>> enabled?  I don't see anything like CONFIG_BINDER_VERBOSE_DEBUG in the
>> config:
>> https://github.com/google/syzkaller/blob/master/dashboard/config/upstream-kasan.config
>> Also no mentions of binder in sysctl/cmline.
>> All binder maintainers are in CC already, perhaps they can shed some
>> light on this.
> 
> Some are enabled by default here:
> https://github.com/torvalds/linux/blob/master/drivers/android/binder.c#L138
> 
> Perhaps we should revise that set then, as it can be quite noisy when
> lots of processes are dying (which also happens a lot in syzbot
> tests).
> 

OK. Then, I think we should consider disabling by default or latelimit printk().
Repeating hundreds of (or maybe thousands of ?) similar messages is not useful
(and blocking other threads due to processing flood of printk() is not good).
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux