On Tue, Feb 22, 2011 at 03:32:40PM -0800, Hank Janssen wrote: > This group of patches removes all DPRINT from hv_vmbus.ko. > It is divided in several patches due to size. Why say this in the 1/6 patch? It should be in the 0/6 introduction. > > All DPRINT calls have been removed, and where needed have been > replaced with pr_XX native calls. Many debug DPRINT calls have > been removed outright. I think a lot of these pr_XX calls can be switched to dev_XX calls instead, right? How about you break this up into a different series of patches to make it more readable: - remove unneeded DPRINT calls - convert remaining DPRINT calls to pr_XX or dev_XX as needed That would make it easier to review, as it is, it's quite difficult. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
