On Mon, Jul 09, 2018 at 11:08:58AM +1000, NeilBrown wrote: > On Sun, Jul 08 2018, Sergio Paracuellos wrote: > > > This patch series clean up a bit mt7621-pci driver. > > > > Changes from v2: > > - It includes new 17 patches from PATCH 2 to PATCH 18 > > - PATCH 1 was send before alone and is being included > > as it is in this new series. > > > > Hope this helps. > > Thanks, > I haven't looked though the patches yet, only tested them. > With the two fixed to pinctrl that I posted together > with the change to "avoid pointer arithmetics in some macros" > in this series, they appear to work. So > > Tested-by: NeilBrown <neil@xxxxxxxxxx> > > I may actually look a them later. Thanks for testing this. Greg, I think is still neccessary to split up patch 1 for better reviewing. If not, please let me know. I'll try to do that hopefully tonight. > > Thanks, > NeilBrown Thanks for your effort and support, Neil. Best regards, Sergio Paracuellos > > > > > Best regards, > > Sergio Paracuellos > > > > Sergio Paracuellos (18): > > staging: mt7621-pci: refactor pci related read and writes functions > > staging: mt7621-pci: simplify pci dependant registers arithmetics > > staging: mt7621-pci: avoid pointer arithmetics in some macros > > staging: mt7621-pci: use BIT macro in definitions > > staging: mt7621-pci: use read and writes in set_pcie_phy function > > staging: mt7621-pci: make ASSERT_SYSRST_PCIE and DEASSERT_SYSRST_PCIE > > inline functions > > staging: mt7621-pci: rewrite [read|write]_config functions > > staging: mt7621-pci: factor out mt7621_pci_enable_irqs and > > mt7621_pci_disable > > staging: mt7621-pci: minor refactor in duplicated code > > staging: mt7621-pci: factor out mt7621_pci_enable function > > staging: mt7621-pci: factor out mt7621_pci_configure function > > staging: mt7621-pci: add blank line between declarations and code > > statements > > staging: mt7621-pci: remove unused preprocessor defines > > staging: mt7621-pci: rename RALINK_PCI_CONFIG_DATA_VIRTUAL_REG > > definition > > staging: mt7621-pci: add some common calculations to > > mt7621_pci_get_cfgaddr > > staging: mt7621-pci: fix and remove some comments > > staging: mt7621-pci: factor out mt7621_pci_init_gpios function > > staging: mt7621-pci: add SPDX identifier > > > > drivers/staging/mt7621-pci/pci-mt7621.c | 706 ++++++++++++++------------------ > > 1 file changed, 305 insertions(+), 401 deletions(-) > > > > -- > > 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel