On Sun, Jul 08 2018, Sergio Paracuellos wrote: > > I can try to split this a bit but I don't really know how to do atomic > changes because > of the related things included here. Some suggestions: 1/ MV_READ_DATA is not used. Discard that any anything else that is not used. 2/ MV_WRITE is replaced with writel(), MV_READ() with readl(). Make that one patch. 3/ unsigned int becomes u32. That is a patch by itself. (maybe this has to go before 2. 4/ Introduce mt7621_pci_get_cfgaddr() and use it where it is a drop-in replacement. 5/ Introduce new implementations of pci_config_read() and pci_config_write. 6/ discard any newly dead code (e.g write_config_* ??) Now if there is anything left in the patch is should be clear if it could benefit from being broken up. Thanks for working on this. NeilBrown
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
