On 23/02/11 13:25, Manohar Vanga wrote: > Fix loop condition in vme_register_bridge that results in an infinite > loop in the event that device_register fails. > > Signed-off-by: Manohar Vanga <manohar.vanga@xxxxxxx> Acked-by: Martyn Welch <martyn.welch@xxxxxx> > --- > drivers/staging/vme/vme.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c > index 88bf455..c1ec230 100644 > --- a/drivers/staging/vme/vme.c > +++ b/drivers/staging/vme/vme.c > @@ -1364,7 +1364,7 @@ int vme_register_bridge(struct vme_bridge *bridge) > return retval; > > err_reg: > - while (i > -1) { > + while (--i >= 0) { > dev = &bridge->dev[i]; > device_unregister(dev); > } -- Martyn Welch (Principal Software Engineer) | Registered in England and GE Intelligent Platforms | Wales (3828642) at 100 T +44(0)127322748 | Barbirolli Square, Manchester, E martyn.welch@xxxxxx | M2 3AB VAT:GB 927559189 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel