Re: [PATCH 2/2] staging: goldfish: cleanup in goldfish_audio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 28, 2018 at 06:19:14PM -0700, rkir@xxxxxxxxxx wrote:
> From: Roman Kiryanov <rkir@xxxxxxxxxx>
> 
> * added a mutex to protect open/read/write/release calls;
> * put the global atomic counter for opened files into the
>     driver state;
> * retired the global variable for the driver state;
> * retired the ioctl calls because it does not do much and cmd=315
>     looks obsolete.

When you have to provide a list of things you are doing in a single
patch, that is a huge hint you need to split that patch up into smaller
pieces.  Each of these bullets should be a single patch.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux